led: Fixed setting of STATUS_LED_BIT1 when led_name is 'all'

Fix for only one led getting set or reset when the led_name is 'all'

Previous discussion:
http://lists.denx.de/pipermail/u-boot/2011-May/093068.html

Changes since v1:
Fixed checkpatch if statement error noticed by Sergei.

Signed-off-by: Joel A Fernandes <[email protected]>
Signed-off-by: Jason Kridner <[email protected]>
Cc: Sergei Shtylyov <[email protected]>
Signed-off-by: Sandeep Paulraj <[email protected]>

diff --git a/common/cmd_led.c b/common/cmd_led.c
index d14dd5adab5d65a10aff55fd8304540ff51e9389..183dc0b42f7663769f56e4e8995edad342cf9960 100644 (file)
--- a/common/cmd_led.c
+++ b/common/cmd_led.c
@@ -108,7 +108,9 @@ int do_led (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
                        } else {
                                __led_set(led_commands[i].mask, state);
                        }
-                       break;
+                       /* Need to set only 1 led if led_name wasn't 'all' */
+                       if (strcmp("all", argv[1]) != 0)
+                               break;
                }
        }